Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[refactor/#211/performance] - 메타태그 오류 수정 #212

Merged
merged 4 commits into from
Apr 8, 2024
Merged

[refactor/#211/performance] - 메타태그 오류 수정 #212

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
5359cbc
[Remove 🗑️] 페이지별 메타태그 삭제
Whoknow77 Apr 7, 2024
69a91b7
[Version 🔖] react-helmet-async 패키지 삭제
Whoknow77 Apr 7, 2024
b906066
[Refactoring ⚙️] 중복 description 제거 및 미리보기 이미지 svg에서 png 변경
Whoknow77 Apr 7, 2024
5ec1b20
[Remove 🗑️] react-helmet-async 의존성삭제
Whoknow77 Apr 8, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
16 changes: 16 additions & 0 deletions index.html
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -20,6 +20,22 @@
<meta
name="google-site-verification"
content="G9-vlZUKpRFQ-pX9B2JO77P4Oc2ZCAbWeNPRfBpnQe8" />
<title>사이드픽(SidePeek)</title>
<meta
name="description"
content="사이드 프로젝트를 공유하고 구경해보세요!" />
<meta
property="og:title"
content="사이드픽 - 사이드 프로젝트를 공유하고 구경해보세요!" />
<meta
property="og:image"
content="https://i.postimg.cc/3N44wNn6/logo.png" />
<meta
property="og:type"
content="website" />
<meta
property="og:url"
content="{`${window.location.origin}${location.pathname}`}" />
</head>
<body>
<div id="root"></div>
Expand Down
15 changes: 0 additions & 15 deletions package-lock.json
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

1 change: 0 additions & 1 deletion package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -33,7 +33,6 @@
"react": "^18.2.0",
"react-dom": "^18.2.0",
"react-dropzone": "^14.2.3",
"react-helmet-async": "^2.0.4",
"react-hook-form": "^7.50.1",
"react-intersection-observer": "^9.8.1",
"react-router-dom": "^6.22.0",
Expand Down
5 changes: 1 addition & 4 deletions src/App.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,4 @@
import { Suspense } from "react"
import { HelmetProvider } from "react-helmet-async"
import { RouterProvider } from "react-router-dom"

import { ChakraProvider, ColorModeScript } from "@chakra-ui/react"
Expand Down Expand Up @@ -35,9 +34,7 @@ const App = () => {
<ColorModeScript initialColorMode="light" />
<ErrorBoundaries>
<Suspense fallback={<FullScreenSpinner />}>
<HelmetProvider>
<RouterProvider router={router} />
</HelmetProvider>
<RouterProvider router={router} />
</Suspense>
</ErrorBoundaries>
</ChakraProvider>
Expand Down
67 changes: 0 additions & 67 deletions src/components/ MetaData/MetaData.tsx
View file
Open in desktop

This file was deleted.

3 changes: 0 additions & 3 deletions src/pages/HomePage/HomePage.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,7 +1,5 @@
import { Fade, Skeleton } from "@chakra-ui/react"

import { HomePageMetaData } from "@components/ MetaData/MetaData"

import Banner from "./components/Banner/Banner"
import ProjectListSection from "./components/ProjectListSection/ProjectListSection"
import { useBannerProjectQuery } from "./hooks/queries/useBannerProjectQuery"
Expand All @@ -11,7 +9,6 @@ const HomePage = () => {

return (
<Fade in={true}>
<HomePageMetaData />
{isBannerLoading ? (
<Skeleton height="35rem" />
) : (
Expand Down
2 changes: 0 additions & 2 deletions src/pages/ProjectDetailPage/ProjectDetailPage.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,6 @@ import { Box, Fade, Flex } from "@chakra-ui/react"

import FullScreenSpinner from "@components/LoadingComponents/FullScreenSpinner"

import { ProjectDetailPageMetaData } from "../../components/ MetaData/MetaData"
import Comments from "./components/Comments/Comments"
import Content from "./components/Content/Content"
import { ProjectIdProps, withProjectId } from "./components/Hoc/withProjectId"
Expand All @@ -18,7 +17,6 @@ const ProjectDetailPage = ({ projectId }: ProjectIdProps) => {

return (
<Fade in={true}>
<ProjectDetailPageMetaData />
<Box w="100%">
<Summary projectDetailInfo={projectDetailInfo} />
<Flex
Expand Down
35 changes: 15 additions & 20 deletions src/pages/ProjectDetailPage/components/Content/TechStacks/TechStacks.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -39,26 +39,21 @@ const TechStacks = ({ techStacks }: TechStacksProps) => {
<HStack
spacing="1rem"
flexWrap="wrap">
{skillList.map((skill, index) => {
console.log(
skill.iconImageUrl?.split(/\//).at(-1)?.split(/\./)[0],
)
return (
<CommonTag
leftElement={
<Image
src={skill.iconImageUrl}
alt=""
w="2rem"
/>
}
cursor="default"
label={skill.name}
key={`${skill.id}-${index}`}
fontSize="lg"
/>
)
})}
{skillList.map((skill, index) => (
<CommonTag
leftElement={
<Image
src={skill.iconImageUrl}
alt=""
w="2rem"
/>
}
cursor="default"
label={skill.name}
key={`${skill.id}-${index}`}
fontSize="lg"
/>
))}
</HStack>
</Stack>
)
Expand Down
2 changes: 0 additions & 2 deletions src/routes/layouts/DefaultLayout.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,6 @@ import { Outlet } from "react-router"

import { Box, Flex, Spacer } from "@chakra-ui/react"

import { DefaultMetaData } from "@components/ MetaData/MetaData"
import Footer from "@components/Footer/Footer"
import Header from "@components/Header/Header"
import Prefetcher from "@components/PreFetcher/Prefetcher"
Expand All @@ -12,7 +11,6 @@ import ScrollToTop from "../ScrollToTop/ScrollToTop"
const DefaultLayout = () => {
return (
<Prefetcher>
<DefaultMetaData />
<Flex
direction="column"
minHeight="100vh">
Expand Down