Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Status: Colorize bluetooth icons (16px-24px) #468

Draft
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

newhoa
Copy link
Contributor

@newhoa newhoa commented Jul 1, 2024

Might hold of merging these "colorize status icon" PRs for a little while. I'd rather get more of them ready and do them at once so it doesn't feel broken or incomplete with some color and some monochromatic.

More testing is probably needed on these to make sure they work across DEs. It will also give time for some user feedback.

Might try to complete a HiDPI option before merging so that there will exist a HiDPI version with the monochromatic panel icons. For those who prefer them, a HiDPI version including them will give them a lot more longevity.


Use full-color icons for bluetooth. These icons match the rest of the color theme better and are easier to see in both light and dark themes. Using full-color icons for these lower sizes now matches the look of the existing bluetooth icons at 32px and above.

Remove monochromatic bluetooth icons from the panel folder. Symbolic icons (which automatically recolorize) are now common so these monochromatic icons should no longer be needed. In places where developers have chosen not to use symbolic icons, we shouldn't force the look. This also solves an issue where the monochromatic icons were difficult to see with mixed light and dark themes (especially with per-app light and dark theme preferences becoming more common).

Use full-color icons for bluetooth. These icons
match the rest of the color theme better and
are easier to see in both light and dark themes.
Using full-color icons for these lower sizes now
matches the look of the existing bluetooth icons
at 32px and above.

Remove monochromatic bluetooth icons from the `panel` folder.
Symbolic icons (which automatically recolorize) are now common
so these monochromatic icons should no longer be needed.
In places where developers have chosen not to use symbolic icons,
we shouldn't force the look. This also solves an issue where the
monochromatic icons were difficult to see with mixed light and
dark themes (especially with per-app light and dark theme
preferences becoming more common).
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant