String based Algorithms added #654
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I have made a new directory known as string based algorithms in aglorithms directory and have added KMP algorithm inside of it
In this commit I have added RabinKarp algorithm for string matching in the StringbasedAlgorithms directory
|
The Label Bot has predicted the following:
|
shhossain
requested changes
Oct 6, 2023
Added comments to KMP and explained the algorithm via an example
Added a new section in the readme for string based algorithms.
…sedalgorithms/KMP/readme.md
…ringbasedalgorithms/RabinKarp/readme.md
Added a readme file for KMP explained it using an example and also added the code for implementing it in the readme
Added a a readme version for Rabin Karp algorithm and ran it on system tests
added a new readme file in the directory string based algorithms all new code snippets and algorithms can now be added here making it easier and less complex than merging all in one
I have applied the changes that you had mentioned in my code and also updated the readme file |
I have added a readme file that contains code for one of the most important string based searching algorithms which is KMP
Created a readme file where I have provided in depth explanation for Rabin Karp algorithm for string based pattern searching
|
I have changed the name of the folder and have written code in the format as you had mentioned. Please review my changes |
|
@all-contributors add @architO21 for code and content. |
|
I've put up a pull request to add @architO21! 🎉 |
|
Thankyou @shhossain this was my first contribution in open source, I got to learn a lot working with you |
|
Congratulations on your first open-source contribution! I'm glad you had a great learning experience. Keep it up! @architO21 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed changes
I have added a new directory known as String based algorithms and added string matching codes inside of it
Types of changes
What types of changes does your content introduce to this project?
Put an
xin the boxes that apply (without "`")Checklist
Put an
xin the boxes that apply. You can also fill these out after creating the PR. Don't hesitate to ask if you're unsure about any of them. We're here to help! This simply reminds us of what we will look for before merging your code.Note: If you submit code make sure to test it
Further comments
If this is a relatively large or complex change, kick off the discussion by explaining why you chose the solution you did and what alternatives you considered, etc...
Adding your name to the contributor's list
Comment "@all-contributors please add @your_username for content" to add your name to the contributor's list.
You can change the "content" with any of this
Reviewers:
Please ensure that you are not adding any sensitive information like API keys, secrets, passwords, tokens, usernames, or other credentials. Refrain from adding your name, email, or other personal information.