Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allows derivation fallback messages to be suppressed #719

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

nadenf
Copy link
Contributor

@nadenf nadenf commented Aug 8, 2024

Fixes #718

Need to update compiler targets as they are falling with newer Scala/Java versions.

@nadenf nadenf force-pushed the fix-warning branch 7 times, most recently from 078856c to fff7a82 Compare August 10, 2024 10:26
@shadaj
Copy link
Owner

shadaj commented Aug 27, 2024

Rather than blanket-disabling these, we should probably have a flag on the Reader/Writer type that declares whether it is for hot-reloading purposes or for external components. Because we don't want to suppress this warning for externals, since that could lead to broken behavior.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Using fallback derivation messages are not suppressible
3 participants