Don't add 200px left margin for toolbar on sign-in page. #404
Conversation
| // TODO?: Are there better ways to achieve this? | ||
| //Sets purple background for student profile and instructions routes | ||
| const isPurpleBg = | ||
| router.asPath.includes("/studentprofile") || | ||
| router.asPath.includes("/instructions"); | ||
| const hasNavBar = "authenticated" == status; |
There was a problem hiding this comment.
This replicates here the logic in the NavBar component to decide if the NavBar should be displayed:
compass/src/components/navbar/NavBar.tsx
Line 109 in 619dac8
There was a problem hiding this comment.
Does what it says, looks good to me. I'm wondering if there's an original sin with this whole issue in that the Drawer component that the Navbar uses should be able to take care of the spacing itself without having to add a margin to its sibling, but that's a more complicated issue that someone else could look into later. In the meantime, I'm happy to approve this and to get all my future sessions start off on a better foot.
|
Thanks, @KCCPMG !
Agreed. It might also be worth looking into using per-page layouts to have different layouts for different pages. Right now, it seems like the sign-in page is the only exception, so that's probably overkill. If in the future there's a need for more pages that either don't have the nav bar or require other layouts, it may be worth it. For the moment though, the change in this PR seemed to me to be the least disruptive improvement. I'll merge it. |
Fix to only add the
margin-left: 200pxneeded for the navigation side bar on pages other than the sign-in page.Fixes #403.