Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

364 ticket, changed subgoal to benchmark #381

Open
wants to merge 7 commits into
base: main
Choose a base branch
from
Open

364 ticket, changed subgoal to benchmark #381

wants to merge 7 commits into from

Conversation

j-h-li
Copy link
Contributor

@j-h-li j-h-li commented Aug 14, 2024

changed subgoal to benchmark

@BeeSeeWhy BeeSeeWhy self-requested a review August 23, 2024 00:22
BeeSeeWhy
BeeSeeWhy requested changes Aug 23, 2024
View reviewed changes
Copy link
Contributor

@BeeSeeWhy BeeSeeWhy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The changes look good, but it looks like there are some conflicts that need to be resolved before we can merge. Also, I don't see components/benchmark folder added along the files, but I see components/subgoal files deleted. Should this all be deleted?
Screenshot 2024-08-22 at 5 33 49 PM

@francisli francisli linked an issue Sep 18, 2024 that may be closed by this pull request
Rename "subgoal" copy to "benchmark" #364
Open
@thomhickey
Copy link
Contributor

The changes look good, but it looks like there are some conflicts that need to be resolved before we can merge. Also, I don't see components/benchmark folder added along the files, but I see components/subgoal files deleted. Should this all be deleted? Screenshot 2024-08-22 at 5 33 49 PM

Yes @BeeSeeWhy, those files need to be replaced or references to them need to be removed, but the missing files are causing problems as there are still imports pointing to them.

@KCCPMG
Copy link
Contributor

KCCPMG commented Oct 22, 2024

The changes look good, but it looks like there are some conflicts that need to be resolved before we can merge. Also, I don't see components/benchmark folder added along the files, but I see components/subgoal files deleted. Should this all be deleted? Screenshot 2024-08-22 at 5 33 49 PM

I believe this is good to go. There is src/components/benchmarks, let me know if there's anything else that you notice as being out of place or missing.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@BeeSeeWhy BeeSeeWhy BeeSeeWhy requested changes

Requested changes must be addressed to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Rename "subgoal" copy to "benchmark"
4 participants
@j-h-li @thomhickey @KCCPMG @BeeSeeWhy