Skip to content

Commit

Permalink
chore: disable Go toolchain download (ignite#3656)
Browse files Browse the repository at this point in the history
* chore: disable Go toolchain download

We must disable toolchain download to allow `go mod tidy` to work.
We are disabling GOMODSUM because of timeouts triggered because of the
size of the CLI repo. Disabling GOMODSUM makes toolchain download fail.
See: https://go.dev/doc/toolchain#download

* chore: update changelog
  • Loading branch information
jeronimoalbi authored and devbv committed Aug 12, 2024
1 parent 40694df commit 0459021
Show file tree
Hide file tree
Showing 2 changed files with 27 additions and 1 deletion.
24 changes: 24 additions & 0 deletions changelog.md
Original file line number Diff line number Diff line change
@@ -1,5 +1,29 @@
# Changelog

## Unreleased

### Features

- [#3476](https://github.com/ignite/cli/pull/3476) Use `buf.build` binary to code generate from proto files
- [#3614](https://github.com/ignite/cli/pull/3614) feat: use DefaultBaseappOptions for app.New method
- [#3536](https://github.com/ignite/cli/pull/3536) Change app.go to v2 and add AppWiring feature

### Changes

- [#3581](https://github.com/ignite/cli/pull/3581) Bump cometbft and cometbft-db in the template
- [#3559](https://github.com/ignite/cli/pull/3559) Bump network plugin version to `v0.1.1`
- [#3522](https://github.com/ignite/cli/pull/3522) Remove indentation from `chain serve` output
- [#3601](https://github.com/ignite/cli/pull/3601) Update ts-relayer version to `0.10.0`
- [#3656](https://github.com/ignite/cli/pull/3656) Disable Go toolchain download

### Fixes

- [#3592](https://github.com/ignite/cli/pull/3592) Fix `pkg/protoanalysis` to support HTTP rule parameter arguments
- [#3598](https://github.com/ignite/cli/pull/3598) Fix consensus param keeper constructor key in `app.go`
- [#3610](https://github.com/ignite/cli/pull/3610) Fix overflow issue of cosmos faucet in `pkg/cosmosfaucet/transfer.go` and `pkg/cosmosfaucet/cosmosfaucet.go`
- [#3618](https://github.com/ignite/cli/pull/3618) Fix TS client generation import path issue
- [#3631](https://github.com/ignite/cli/pull/3631) Fix unnecessary vue import in hooks/composables template

## [`v0.27.0`](https://github.com/ignite/cli/releases/tag/v0.27.0)

### Features
Expand Down
4 changes: 3 additions & 1 deletion ignite/pkg/gocmd/gocmd.go
Original file line number Diff line number Diff line change
Expand Up @@ -91,7 +91,9 @@ func ModTidy(ctx context.Context, path string, options ...exec.Option) error {
// FIXME(tb) untagged version of ignite/cli triggers a 404 not found when go
// mod tidy requests the sumdb, until we understand why, we disable sumdb.
// related issue: https://github.com/golang/go/issues/56174
exec.StepOption(step.Env("GOSUMDB=off")),
// Also disable Go toolchain download because it doesn't work without a valid
// GOSUMDB value: https://go.dev/doc/toolchain#download
exec.StepOption(step.Env("GOSUMDB=off", "GOTOOLCHAIN=local+path")),
)...)
}

Expand Down

0 comments on commit 0459021

Please sign in to comment.