Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

I8 return errors as warnings #9

Merged
merged 4 commits into from
Sep 17, 2024
Merged

I8 return errors as warnings #9

merged 4 commits into from
Sep 17, 2024

Conversation

hillalex
Copy link
Member

If the spline model for a disaggregated trace fails, don't throw an error but just return a warning for that trace. Closes #8

@hillalex hillalex marked this pull request as ready for review September 17, 2024 10:50
Copy link

codecov bot commented Sep 17, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 92.90%. Comparing base (bba41d9) to head (3758726).
Report is 5 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main       #9      +/-   ##
==========================================
+ Coverage   92.70%   92.90%   +0.20%     
==========================================
  Files           4        4              
  Lines         274      282       +8     
==========================================
+ Hits          254      262       +8     
  Misses         20       20              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@hillalex hillalex merged commit 58a663b into main Sep 17, 2024
10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Handle errors in disaggregated traces
1 participant