Paging #15
Merged
Paging #15
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hillalex
commented
Sep 25, 2024
| @@ -14,68 +14,61 @@ target_post_dataset <- function(req, res) { | |||
| parsed <- mime::parse_multipart(req) | |||
| xcol <- get_xcol(parsed) | |||
| name <- get_dataset_name(parsed) | |||
| if (is.null(xcol)) { | |||
There was a problem hiding this comment.
reactoring this function not related to other changes but just opportunistic
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #15 +/- ##
==========================================
+ Coverage 93.20% 94.25% +1.04%
==========================================
Files 4 5 +1
Lines 368 383 +15
==========================================
+ Hits 343 361 +18
+ Misses 25 22 -3 ☔ View full report in Codecov by Sentry. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The endpoint
GET /dataset/<name>/indidivudalreturns plotly config for a multi-panel plot; one panel per individual. This PR modifies that endpoint to take apagequery string parameter and return a given page of (up to)f 20 panels.