Skip to content

Commit

Permalink
fix!: deployment default values (#1379)
Browse files Browse the repository at this point in the history
  • Loading branch information
@TartanLeGrand
TartanLeGrand authored Aug 15, 2024
1 parent a284f91 commit 72376fd
Show file tree
Hide file tree
Showing 2 changed files with 19 additions and 6 deletions.
2 changes: 1 addition & 1 deletion .github/workflows/lint-test.yaml
View file
Original file line number Diff line number Diff line change
Expand Up @@ -7,7 +7,7 @@ jobs:
runs-on: ubuntu-latest
steps:
- name: Checkout
uses: actions/checkout@v3
uses: actions/checkout@v4
with:
fetch-depth: 0

Expand Down
23 changes: 18 additions & 5 deletions charts/sentry/values.yaml
View file
Original file line number Diff line number Diff line change
Expand Up @@ -197,7 +197,7 @@ sentry:

worker:
enabled: true
replicas: 3
replicas: 1
# concurrency: 4
env: []
resources: {}
Expand All @@ -214,7 +214,7 @@ sentry:
maxReplicas: 5
targetCPUUtilizationPercentage: 50
livenessProbe:
enabled: false
enabled: true
periodSeconds: 60
timeoutSeconds: 10
failureThreshold: 3
Expand Down Expand Up @@ -1619,6 +1619,14 @@ nginx:
ports:
http: 80
extraLocationSnippet: false
customReadinessProbe:
tcpSocket:
port: http
initialDelaySeconds: 5
timeoutSeconds: 3
periodSeconds: 5
successThreshold: 1
failureThreshold: 3
# extraLocationSnippet: |
# location /admin {
# allow 1.2.3.4; # VPN network
Expand All @@ -1631,7 +1639,7 @@ nginx:
# name: nginx

ingress:
enabled: false
enabled: true
# If you are using traefik ingress controller, switch this to 'traefik'
# if you are using AWS ALB Ingress controller, switch this to 'aws-alb'
# if you are using GKE Ingress controller, switch this to 'gke'
Expand Down Expand Up @@ -1727,6 +1735,7 @@ config:

clickhouse:
enabled: true
replicas: "1"

This comment has been minimized.

Sign in to view

Copy link
@mosesdd

mosesdd Aug 19, 2024

@TartanLeGrand this is in the wrong section, it needs to be
clickhouse:
clickhouse:
replicas: "1"

This comment has been minimized.

Sign in to view

Copy link
@mosesdd

mosesdd Aug 19, 2024

@TartanLeGrand I also noticed its not possible to update the chart clickhouse replicas set to 1 if it was default 3 before:

│ Traceback (most recent call last): │
│ File "/usr/local/bin/snuba", line 33, in │
│ sys.exit(load_entry_point('snuba', 'console_scripts', 'snuba')()) │
│ ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ │
│ File "/usr/local/lib/python3.11/site-packages/click/core.py", line 1130, in call │
│ return self.main(*args, **kwargs) │
│ ^^^^^^^^^^^^^^^^^^^^^^^^^^ │
│ File "/usr/local/lib/python3.11/site-packages/click/core.py", line 1055, in main │
│ rv = self.invoke(ctx) │
│ ^^^^^^^^^^^^^^^^ │
│ File "/usr/local/lib/python3.11/site-packages/click/core.py", line 1657, in invoke │
│ return _process_result(sub_ctx.command.invoke(sub_ctx)) │
│ ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ │
│ File "/usr/local/lib/python3.11/site-packages/click/core.py", line 1657, in invoke │
│ return _process_result(sub_ctx.command.invoke(sub_ctx)) │
│ ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ │
│ File "/usr/local/lib/python3.11/site-packages/click/core.py", line 1404, in invoke │
│ return ctx.invoke(self.callback, **ctx.params) │
│ ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ │
│ File "/usr/local/lib/python3.11/site-packages/click/core.py", line 760, in invoke │
│ return __callback(*args, **kwargs) │
│ ^^^^^^^^^^^^^^^^^^^^^^^^^^^ │
│ File "/usr/src/snuba/snuba/cli/migrations.py", line 104, in migrate │
│ check_for_inactive_replicas(get_all_storage_keys(readiness_states=readiness_states)) │
│ File "/usr/src/snuba/snuba/migrations/connect.py", line 194, in check_for_inactive_replicas │
│ raise InactiveClickhouseReplica("\n".join(sorted(set(inactive_replica_info)))) │
│ snuba.migrations.errors.InactiveClickhouseReplica: Storage group_attributes has inactive replicas for table groupassignee_local with 1 out of 3 replicas active. │
│ Storage group_attributes has inactive replicas for table groupedmessage_local with 1 out of 3 replicas active.
clickhouse:
imageVersion: "21.8.13.6"
configmap:
Expand Down Expand Up @@ -1794,7 +1803,7 @@ externalClickhouse:
zookeeper:
enabled: true
nameOverride: zookeeper-clickhouse
replicaCount: 3
replicaCount: 1

# Settings for Kafka.
# See https://github.com/bitnami/charts/tree/master/bitnami/kafka
Expand Down Expand Up @@ -1918,6 +1927,8 @@ kafka:
enabled: false
kraft:
enabled: true
controller:
replicaCount: 1

## Use this to enable an extra service account
# serviceAccount:
Expand All @@ -1943,6 +1954,8 @@ sourcemaps:

redis:
enabled: true
replica:
replicaCount: 1
auth:
enabled: false
sentinel: false
Expand Down Expand Up @@ -2015,7 +2028,7 @@ rabbitmq:
clustering:
forceBoot: true
rebalance: true
replicaCount: 3
replicaCount: 1
auth:
erlangCookie: pHgpy3Q6adTskzAT6bLHCFqFTF7lMxhA
username: guest
Expand Down

0 comments on commit 72376fd

Please sign in to comment.