Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Initial Design document finalize #1

Open
wants to merge 87 commits into
base: main
Choose a base branch
from
Open

Initial Design document finalize #1

wants to merge 87 commits into from

Conversation

tekrajchhetri
Copy link
Collaborator

@tekrajchhetri tekrajchhetri commented Apr 23, 2024

This PR adds the following:

  1. Initial design document providing overview of BrainyPedia
  2. Principles of BrainyPedia
  3. Initial microservices based architecture.
  4. Other considerations that BrainyPedia makes
  5. Sequence diagram demonstrating steps and the interactions amongst different components for manual KG construction.

@satra

@tekrajchhetri tekrajchhetri added the documentation Improvements or additions to documentation label Apr 23, 2024
@satra
Copy link

satra commented Apr 23, 2024

@tekrajchhetri - take a look at the embargo and other design docs in dandi-archive and update this to reflect that. break the document into:

  • use-cases (this should include)
  • target audience groups
  • architecture details (specific approaches and components)
  • implementation plan

for the sequence diagram, insert the mermaid code directly in the markdown.

please work directly with @puja-trivedi on the design and ping @djarecka for reviews.

@tekrajchhetri tekrajchhetri requested review from djarecka and removed request for satra April 24, 2024 19:29
Copy link

@djarecka djarecka left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@tekrajchhetri - I've left bunch of comments/questions. Basically, I asked all the questions I had when reading since many points were very general. However, I'm not sure if you are ready to answer all the questions. If something will have to be specified later (e.g. after seeing data, or talking to other people), perhaps it should be clarified?

fyi. i have not checked the architecture

README.md Outdated Show resolved Hide resolved
README.md Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
README.md Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
@tekrajchhetri tekrajchhetri changed the title Initial Design document Initial Design document - complete May 29, 2024
@tekrajchhetri tekrajchhetri changed the title Initial Design document - complete Initial Design document May 29, 2024
@tekrajchhetri
Copy link
Collaborator Author

Hi @tekrajchhetri thanks for your patience. In general I love the vision you've laid out in the doc, and the doc lays out a compelling high level technical approach (principles & architecture).

As a technical design doc, I feel like there's a lot of detail missing. I would expect data models, API models, deployment & testing approaches, etc. If that doesn't jive with your approach - e.g. you're just planning to start working on the high level aims in this doc and get feedback as you go - that can work too; in that case I would strongly suggest you add a "workplan" section and list out - in priority order - what features you plan to add, so others & I can give feedback on that prioritization.

I'd also suggest you add a section about hosting infrastructure: the beta site is very slow right now (totally fine!) so I'm sure you have thoughts on how to improve the performance, stability, IaC, etc., and it's worth spelling that out a bit. If you don't think you'll be able to harden the tool in those ways, that's OK too, but that would be good context to document so others & I can consider how this tool fits into the overall project most effectively.

Best, Tyler

Thanks @tylenolncuff, I will update the design document accordingly.

README.md Outdated Show resolved Hide resolved
@candleindark
Copy link

Screenshot 2024-07-31 at 12 05 02 PM

I think the phrase "content moderation of the content" can be just "content moderation".

@tekrajchhetri
Copy link
Collaborator Author

Screenshot 2024-07-31 at 12 05 02 PM

I think the phrase "content moderation of the content" can be just "content moderation".

Thank you for catching it, I will update the document

Co-authored-by: Isaac To <[email protected]>
@candleindark
Copy link

Screenshot 2024-07-31 at 12 34 11 PM

I think the boxed section is a redundant since providing a platform is a way of facilitating.

(Sorry for the spams. I don't have the application to edit the vsdx file).

README.md Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
README.md Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
tekrajchhetri and others added 6 commits August 1, 2024 13:32
Co-authored-by: Isaac To <[email protected]>
Co-authored-by: Isaac To <[email protected]>
Co-authored-by: Isaac To <[email protected]>
Co-authored-by: Isaac To <[email protected]>
Co-authored-by: Isaac To <[email protected]>
Co-authored-by: Isaac To <[email protected]>
@tekrajchhetri
Copy link
Collaborator Author

Screenshot 2024-07-31 at 12 34 11 PM

I think the boxed section is a redundant since providing a platform is a way of facilitating.

(Sorry for the spams. I don't have the application to edit the vsdx file).

@candleindark You would need to edit using the Microsoft Visio. If you have access to Office 365 then you should have also access to the visio. I have shared the link with you via slack.

@tekrajchhetri
Copy link
Collaborator Author

Screenshot 2024-07-31 at 12 34 11 PM
I think the boxed section is a redundant since providing a platform is a way of facilitating.
(Sorry for the spams. I don't have the application to edit the vsdx file).

@candleindark You would need to edit using the Microsoft Visio. If you have access to Office 365 then you should have also access to the visio. I have shared the link with you via slack.

I have updated the image now as per your comment

@candleindark
Copy link

Screenshot 2024-07-31 at 12 34 11 PM
I think the boxed section is a redundant since providing a platform is a way of facilitating.
(Sorry for the spams. I don't have the application to edit the vsdx file).

@candleindark You would need to edit using the Microsoft Visio. If you have access to Office 365 then you should have also access to the visio. I have shared the link with you via slack.

Great. After some poking around, I found out my access for Office365 through Dartmouth. Thanks.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation
Projects
Status: In Progress
Development

Successfully merging this pull request may close these issues.

6 participants