test: adds receive_message test #11
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
blocks were used from flat files decoder, which means it is no longer coupled to this dependency. Also commented functions that will be moved to flat_head
…ords and Header from portalapi
|
I just opened an issue on Ethportal api, to add |
adds optional lockfile usage, helps testing
…oder without using wrappers sf-protos contains the dependencies from the proto files that are used both in the header accumulator and flat files decoder. This means that both of them can share a single instance of a type without implementing try_from conversions or similar
…ecords-function): extract_100_blocks is not necessary in header acc anymore, since block handling is now done by flat files decoder. ext_header_from_block now hande singular blocks and should be used inside a .map() for conversion of Block arrays
…ion and generation after refactor
flat-files decoder is now only used in tests to facilitate validating header_accumulator functions
|
Basically, I've used sf-protos to interchange types between header_accumulator and flat-files-decoder without having to rely on external crates conversions. Before merging, I will make sure that the |
…exists as a From trait implementation
|
From here onwards, most commits are tests to attempt to achieve at least 80% coverage. |
severiano-sisneros
requested changes
Mar 14, 2024
… warns against post-merge blocks
severiano-sisneros
approved these changes
Mar 18, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Some more things had to be refactored in order to remove
flat-files-decoderentirely from this crate. This will be merged intorefactorbranch because it is a specific part of era_validate that needs to be validate in the other 2 repos before merging, so having a new branch specifically for this helps in that.