optionally parse broker index from hostname #86
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zyannes
previously approved these changes
Sep 19, 2024
zyannes
previously approved these changes
Sep 19, 2024
|
Going to take a different approach to multiple brokers |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We should encourage folks to run multiple brokers in a StatefulSet, if they're running in Kubernetes. This PR adds an optional config field to parse the broker index from the hostname so that users don't have to deal with manually setting indexes.
Logic: (trying to find the right balance of explicit vs. "just works")
inbound.wireguard.brokerIndexHostnameRegexis set, compile the regex (fail fast if invalid)--broker-indexcommand line arg is set and >= 0, just use and ignore the other config settingsinbound.wireguard.brokerIndexHostnameRegexis set, attempt to match against the hostname.a. Fail fast if we get an anomalous result (e.g. regex is missing a capture group or we fail to convert the capture group to an integer)
b. Fall through if there's simply no regex match (i.e. we shouldn't panic if the broker is not deployed as a StatefulSet)
inbound.wireguard.brokerIndexconfig value is (default0)(default value of
inbound.wireguard.brokerIndexHostnameRegexis^.+-([0-9]+)$which should work for stateful sets.