Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

extend allowlist for scms #80

Merged
merged 6 commits into from
Jul 27, 2024
Merged

extend allowlist for scms #80

merged 6 commits into from
Jul 27, 2024

Conversation

vivekkhimani
Copy link
Member

@vivekkhimani vivekkhimani commented Jul 27, 2024 •
edited
Loading

  • Add missing URLs to gitlab allowlist
  • Add missing URLs to github allowlist
  • Add missing URLs to bitbucket allowlist
    • code access endpoints are WIP for this, will add it once they go live.
  • update readme

@vivekkhimani vivekkhimani changed the title expand gitlab allowlist extend allowlist for scms Jul 27, 2024
@vivekkhimani vivekkhimani marked this pull request as ready for review July 27, 2024 19:43
@vivekkhimani vivekkhimani requested a review from tpetr as a code owner July 27, 2024 19:43
tpetr
tpetr previously approved these changes Jul 27, 2024
View reviewed changes
Copy link
Contributor

@tpetr tpetr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, just one minor nit

README.md Show resolved Hide resolved
@vivekkhimani vivekkhimani requested a review from tpetr July 27, 2024 22:19
@vivekkhimani vivekkhimani merged commit db4525e into develop Jul 27, 2024
4 checks passed
@vivekkhimani vivekkhimani deleted the vivek/more-allowlist branch July 27, 2024 22:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tpetr tpetr tpetr approved these changes

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@vivekkhimani @tpetr