Missing mobile device families #80
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
these device family names were found by running the parser against a Parse.ly internal dataset of user agents the parser had incorrectly identified as mobile. fixes selwin#73
|
Thanks for the PR. This library doesn't aim to hardcode every single device families available because that's not a scalable approach but rather look for heuristics. May I know which movile devices that are currently not properly detected? |
|
@selwin Thanks for being in touch. This PR was just meant to start a discussion, since there are a fair number of mobile devices being incorrectly identified as tablets. The list given here is comprehensive as far as we're concerned at Parse.ly. If you'd like to work together on a way to support these devices heuristically rather than explicitly, I'd be happy to help out. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request adds to
MOBILE_DEVICE_FAMILIESa large number of device families that the parser incorrectly identifies asis_mobile() == False. These device families are all mobile phones.These device family names were found by running the parser against a Parse.ly internal dataset of user agents the parser had incorrectly identified as tablets, found by @UdayVarkhedkar.
Fixes #73