Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

selkies image streaming check #62

Open
wants to merge 11 commits into
base: master
Choose a base branch
from
Open

selkies image streaming check #62

wants to merge 11 commits into from

Conversation

deepak7093
Copy link
Contributor

@deepak7093 deepak7093 commented Jul 19, 2022 •
edited
Loading

  • GKE image streaming pre-check for installer, controller and gce-proxy images
  • GAR image tag and push

danisla
danisla reviewed Jul 19, 2022
View reviewed changes
images/cloudbuild.yaml Outdated Show resolved Hide resolved
danisla
danisla reviewed Jul 19, 2022
View reviewed changes
images/cloudbuild.yaml Outdated Show resolved Hide resolved
@deepak7093 deepak7093 closed this Jul 23, 2022
@deepak7093 deepak7093 reopened this Jul 23, 2022
@danisla danisla requested a review from reisbel July 27, 2022 15:25
@danisla danisla self-requested a review August 5, 2022 15:09
@reisbel reisbel self-requested a review August 16, 2022 15:26
reisbel
reisbel reviewed Aug 16, 2022
View reviewed changes
Copy link
Contributor

@reisbel reisbel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please see my comments

images/setup/scripts/check_docker_image.sh Show resolved Hide resolved
setup/infra/image-streaming/main.tf Show resolved Hide resolved
setup/infra/image-streaming/cloudbuild.yaml Outdated Show resolved Hide resolved
setup/infra/image-streaming/sa.tf Outdated Show resolved Hide resolved
@deepak7093 deepak7093 requested review from reisbel and danisla and removed request for danisla and reisbel August 25, 2022 07:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@reisbel reisbel reisbel approved these changes

@danisla danisla Awaiting requested review from danisla

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@deepak7093 @reisbel @danisla