Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add callback for receipt storage #520

Merged
merged 10 commits into from
Jun 27, 2024
Merged

Conversation

stevenlanders
Copy link
Contributor

@stevenlanders stevenlanders commented Jun 21, 2024

Describe your changes and provide context

  • commit handler will invoke necessary logic on sei-chain side

Testing performed to validate your change

  • unit tests

Copy link

codecov bot commented Jun 21, 2024

Codecov Report

Attention: Patch coverage is 35.00000% with 13 lines in your changes missing coverage. Please review.

Project coverage is 55.31%. Comparing base (bf9783f) to head (f14e25c).

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff           @@
##             main     #520   +/-   ##
=======================================
  Coverage   55.31%   55.31%           
=======================================
  Files         631      631           
  Lines       54226    54240   +14     
=======================================
+ Hits        29993    30004   +11     
- Misses      22089    22093    +4     
+ Partials     2144     2143    -1     
Files Coverage Δ
baseapp/abci.go 52.57% <100.00%> (+0.16%) ⬆️
storev2/rootmulti/store.go 2.85% <0.00%> (+0.01%) ⬆️
baseapp/options.go 47.90% <50.00%> (+0.10%) ⬆️
baseapp/baseapp.go 65.52% <0.00%> (-0.57%) ⬇️

... and 2 files with indirect coverage changes

@stevenlanders stevenlanders merged commit ae5ac34 into main Jun 27, 2024
14 of 15 checks passed
@stevenlanders stevenlanders deleted the add-receipt-commit-callback branch June 27, 2024 12:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants