Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

EIP-1559: fix migration handler to update min base fee #1891

Merged
merged 1 commit into from
Oct 8, 2024

Conversation

jewei1997
Copy link
Contributor

Describe your changes and provide context

Migration handler should update min base fee to 1gwei

Testing performed to validate your change

unit tests

Copy link

codecov bot commented Oct 7, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 61.19%. Comparing base (4daa00c) to head (a81b435).
Report is 1 commits behind head on main.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #1891      +/-   ##
==========================================
+ Coverage   61.17%   61.19%   +0.01%     
==========================================
  Files         263      263              
  Lines       23310    23311       +1     
==========================================
+ Hits        14260    14265       +5     
+ Misses       8043     8040       -3     
+ Partials     1007     1006       -1     
Files with missing lines Coverage Δ
x/evm/migrations/migrate_eip_1559_params.go 100.00% <100.00%> (ø)

... and 1 file with indirect coverage changes

@jewei1997 jewei1997 merged commit b9199c6 into main Oct 8, 2024
51 of 52 checks passed
@jewei1997 jewei1997 deleted the eip-1559-fix-default-min-base-fee branch October 8, 2024 12:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants