Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow list. Token factory changes #1844

Merged
merged 30 commits into from
Sep 20, 2024
Merged

Allow list. Token factory changes #1844

merged 30 commits into from
Sep 20, 2024

Conversation

dssei
Copy link
Contributor

@dssei dssei commented Sep 6, 2024

Describe your changes and provide context

This PR implements allow list token extension on top of existing token factory module.
Feature enables specifying a list of addresses that will be allowed to send/receive the token denom

This change depends on:

This change contains:

  • updates to token factory command create-denom with new flag --allow-list
  • add new command update-denom with same flag
  • allow list is a JSON file formatted as { "addresses": ["seiAddress1", "seiAddress2"]}
  • EVM addresses are allowed as well (but will be converted to sei native addresses and persisted as such)
  • add gRPC to query persisted list of allowed addresses

Testing performed to validate your change

  • unit tests
  • performance testing has been done as well for the change
  • functional testing on local and performance test cluster

Copy link

codecov bot commented Sep 6, 2024

Codecov Report

Attention: Patch coverage is 82.45614% with 40 lines in your changes missing coverage. Please review.

Project coverage is 60.90%. Comparing base (fa43819) to head (5db6498).
Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
x/tokenfactory/client/cli/tx.go 71.87% 21 Missing and 6 partials ⚠️
x/tokenfactory/keeper/config.go 62.50% 2 Missing and 1 partial ⚠️
x/tokenfactory/keeper/createdenom.go 90.62% 2 Missing and 1 partial ⚠️
x/tokenfactory/keeper/msg_server.go 93.61% 2 Missing and 1 partial ⚠️
app/app.go 50.00% 1 Missing and 1 partial ⚠️
x/tokenfactory/types/msgs.go 91.30% 2 Missing ⚠️
Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #1844      +/-   ##
==========================================
+ Coverage   60.76%   60.90%   +0.13%     
==========================================
  Files         260      261       +1     
  Lines       22875    23098     +223     
==========================================
+ Hits        13901    14067     +166     
- Misses       7991     8040      +49     
- Partials      983      991       +8     
Flag Coverage Δ
60.90% <82.45%> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
app/test_helpers.go 60.50% <100.00%> (+0.50%) ⬆️
x/tokenfactory/keeper/grpc_query.go 76.08% <100.00%> (+9.42%) ⬆️
x/tokenfactory/keeper/keeper.go 92.85% <100.00%> (+0.54%) ⬆️
app/app.go 66.19% <50.00%> (-0.06%) ⬇️
x/tokenfactory/types/msgs.go 67.85% <91.30%> (+4.60%) ⬆️
x/tokenfactory/keeper/config.go 62.50% <62.50%> (ø)
x/tokenfactory/keeper/createdenom.go 87.17% <90.62%> (+2.39%) ⬆️
x/tokenfactory/keeper/msg_server.go 87.27% <93.61%> (+1.90%) ⬆️
x/tokenfactory/client/cli/tx.go 34.09% <71.87%> (+31.11%) ⬆️

... and 3 files with indirect coverage changes

@dssei dssei self-assigned this Sep 6, 2024
@dssei dssei marked this pull request as ready for review September 18, 2024 00:18
@dssei dssei merged commit cfd8cec into main Sep 20, 2024
49 checks passed
@dssei dssei deleted the feature/token_allow_list branch September 20, 2024 21:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants