Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add online flush policy #863

Closed
wants to merge 1 commit into from
Closed

Add online flush policy #863

wants to merge 1 commit into from

Conversation

zikaari
Copy link
Contributor

@zikaari zikaari commented Jul 27, 2023

No description provided.

@zikaari zikaari requested a review from oscb July 27, 2023 16:34
Copy link
Contributor

@oscb oscb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One note about the readme

Another thing to note, since the automation in this repo uses conventional commits the commit title should be: feat: add online flush policy so that it gets version bumped properly (important just before merging)

@@ -21,6 +21,7 @@
},
"dependencies": {
"@react-native-async-storage/async-storage": "^1.15.7",
"@react-native-community/netinfo": "^9.4.1",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Since this is a native module can you add to the readme that they have to manually install this dependency?

In RN Native dependencies are not autolinked (only the NPM package is installed)

@hvardhan-unth
Copy link
Contributor

Comments resolved in new PR: #889

@alanjcharles alanjcharles deleted the flush_when_online branch July 23, 2024 19:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants