fix: advertising id being sent for Android application installed events using analytics-react-native-plugin-advertsing-id #1015
Conversation
|
Atlantis commands can't be run on fork pull requests. To enable, set --allow-fork-prs or, to disable this message, set --silence-fork-pr-errors |
|
|
🎉 This PR is included in version 2.20.2 🎉 The release is available on npm package (@latest dist-tag) Your semantic-release bot 📦🚀 |
|
🎉 This PR is included in version 1.3.2 🎉 The release is available on npm package (@latest dist-tag) Your semantic-release bot 📦🚀 |
| }else{ | ||
| return event; | ||
| } | ||
| return; |
There was a problem hiding this comment.
What does it means in this context to return undefined? What if there's other plugin that is meant to be executed after this plugin? Does this means that the other plugin won't get anything to process? Will the other plugin indeed eventually get something once we execute process for this event?
| if (this.advertisingId === undefined) { | ||
| this.queuedEvents.push(event); | ||
| }else{ | ||
| return event; | ||
| } | ||
| return; |
There was a problem hiding this comment.
nit: a more clear way for this if could also be:
if (this.advertisingId === undefined) {
this.queuedEvents.push(event);
return;
}
return event;
Fix for - Advertising Id not being sent for Android Application Installed events using analytics-react-native-plugin-advertising-id #995