Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support bell char and decode null char #94

Merged
merged 2 commits into from
Apr 24, 2024

Conversation

lukemurray
Copy link
Contributor

@lukemurray lukemurray commented Apr 15, 2024

Hi, to avoid breaking changes in moving one of my old antler parsers I need to support the bell char and have the null char decoded.

This PR add support for that. There are probably other chars that are valid that might be worth adding.

Or perhaps a way to add extra valid chars to a string.

@sebastienros
Copy link
Owner

Can you update the tests that check this method?
Do you know if these chars are common to most word strings like C#, JavaScript, json for instance? I can look it up.

@lukemurray
Copy link
Contributor Author

They are valid chars in C# and most other languages. Not sure about JSON.

I'll update the tests

@lukemurray
Copy link
Contributor Author

Sorry to bother, just wondering if this is something you will consider merging or if there is anything else needed for the PR? Thanks.

@sebastienros
Copy link
Owner

Thanks, I had not seen the notification that the tests were added.

@sebastienros sebastienros merged commit f1586c8 into sebastienros:main Apr 24, 2024
2 checks passed
@sebastienros
Copy link
Owner

Do you need a new release with this change or are you using the source code directly?

@lukemurray
Copy link
Contributor Author

Thanks. I'd love a release/nuget package.

@lukemurray
Copy link
Contributor Author

Sorry, any chance of a 0.26 release with this?

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants