Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[WIP]feature: add oci registry #2071

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Conversation

jsparter
Copy link
Member

@jsparter jsparter commented Mar 1, 2023

Describe what this PR does / why we need it

Already implement scenario1、2 of #1940. This pr needs to work with basefs pr 40
Now we can use image cache when build stage by specify registryType as "oci" in json file: $HOME/.sealer/config,and run with new basefs after basefs pr 40
config file example:

{
  "registryType": "oci"
}

Does this pull request fix one issue?

Part of #1940#2001

Describe how you did it

Describe how to verify it

Special notes for reviews

@github-actions github-actions bot added the ImageBuilding related to all staff with image building label Mar 1, 2023
pkg/registry/installer.go Outdated Show resolved Hide resolved
cmd/sealer/cmd/cluster/scale-up.go Outdated Show resolved Hide resolved
pkg/define/config.go Show resolved Hide resolved
pkg/image/save/skopeo/copy.go Outdated Show resolved Hide resolved
pkg/image/save/skopeo/copy.go Outdated Show resolved Hide resolved
Signed-off-by: jsparter <[email protected]>
@starnop starnop changed the title feature: add oci registry [WIP]feature: add oci registry Apr 28, 2023
@kakaZhou719 kakaZhou719 mentioned this pull request May 19, 2023
17 tasks
if err := getDestDir(destImageName); err != nil {
return err
}
err := skopeo.Copy(srcImageName, destImageName, creds)
Copy link

@fengxsong fengxsong May 22, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This approach will make it impossible to reuse layers that may be duplicated in all images while building new oci images. that is, the new built image will become large than before.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ImageBuilding related to all staff with image building
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants