-
Notifications
You must be signed in to change notification settings - Fork 106
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
MCS CRefine sorried for RISCV64 #683
Conversation
Looking at the commits for now: The "update copyright" commit (no tags, no explanantion), at least the CRefine parts look like they should be folded into the sorrying run. Not sure about the lib part. For the "rt crefine: finish sorrying run", I know I lost the battle about indicating in the tags that this is only for RISCV64, but maybe I could get a comment in the body of the commit, as it's quite a large commit? For the run_tests and Makefile changes, why are they tagged "rt:", these are not rt specific. The first should say "run_tests: enable CRefine for RISCV64". The second is misleading, as it's RISCV64 only, and also not rt-specific; I'd suggest Gerwin-styled "riscv64 proofs: turn on quick_and_dirty for CRefine". |
314b9d8
to
b96f76d
Compare
b96f76d
to
5e9aa9c
Compare
The run_tests change is still not tagged with I'm trying to push you a bit towards more consistency with the rest of the repo. In future, if you're doing a change to run_tests or something, can you look at a few past commits with Similarly for the manifest commit, if you do |
Finish the CRefine proof setup for RISCV64 on seL4 revision 756a37b7d3c0. Signed-off-by: Michael McInerney <[email protected]>
Update CRefine proof setup for RISCV64 to seL4 revision 4214775. Signed-off-by: Michael McInerney <[email protected]>
Signed-off-by: Michael McInerney <[email protected]>
Allow sorries during development. Signed-off-by: Michael McInerney <[email protected]>
0cee74c
to
3d978d7
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Alright, the commit messages are cleaned up and the content has been good the entire time already, so that is also fine.
Thanks for diligently adding new lemmas for all of the new MCS functions, this makes the sorry-count much more useful.
This sorries the last files in the CRefine session, thereby completing the setup of the proof infrastructure for MCS CRefine.
In addition, this enables testing of the CRefine session via our continuous integration setup.