If cpp_path is relative, make it relative to the current theory. #676
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lsf37
approved these changes
Oct 8, 2023
There was a problem hiding this comment.
Thanks, I think this makes sense.
Can you please add a sign-off line to the commit message for the Developer Certificate of Origin and remove any trailing whitespace from the new lines to placate the whitespace check.
|
@adbrucker ping -- without the sign-off I can't merge your PR. |
adbrucker
force-pushed
the
cpp_path_relative
branch
5 times, most recently
from
44dc9f7
to
809e485
Compare
Signed-off-by: Achim D. Brucker <[email protected]>
Signed-off-by: Achim D. Brucker <[email protected]>
lsf37
force-pushed
the
cpp_path_relative
branch
from
809e485
to
5b34847
Compare
|
(rebased) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If the path configures as "cpp_path" is not an absolute path, convert it to an absolute path by prepending the directory in which the "install_C_file" is used. This makes it easier to share the same configuration across a team using different operating systems.