Remove uses of _tac methods from nondet #671
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
corlewis
commented
Sep 29, 2023
lsf37
approved these changes
Sep 29, 2023
corlewis
force-pushed
the
nondet_remove_tac
branch
from
8a69469
to
b54a6f7
Compare
lsf37
approved these changes
Oct 3, 2023
|
I'm fine with this, no further review comments. Not sure what the motivation for it was, AFP requirements? |
corlewis
force-pushed
the
nondet_remove_tac
branch
from
b54a6f7
to
2f42958
Compare
Yes, AFP requirements |
In particular, try to remove as many as possible _tac methods that refer to system-generated variable names. Any remaining uses are explicitly protected by a rename_tac. Signed-off-by: Corey Lewis <[email protected]>
corlewis
force-pushed
the
nondet_remove_tac
branch
from
2f42958
to
7af193c
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In particular, try to remove as many _tac methods that refer to system-generated variable names as possible. Any remaining uses are explicitly protected by a rename_tac.