More Nondet Monad improvements #666
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lsf37
approved these changes
Aug 23, 2023
Xaphiosis
reviewed
Aug 24, 2023
| imports | ||
| Nondet_Lemmas | ||
| WPSimp | ||
| imports |
There was a problem hiding this comment.
when did we start indenting imports? I know the autoindenter likes to do it, but I'm not sure that that's our policy. @lsf37 ?
There was a problem hiding this comment.
I noticed that most of the files in nondet already had indented imports so I decided to go with the autoindenter and make them consistent. I don't know if we have an official policy, but I'd also be happy to go in the opposite direction and make them consistent with the rest of the repository.
There was a problem hiding this comment.
We probably shouldn't fight the auto indenter on this. We used to not indent them, but I'd be happy with indented import statements (and I think I have done that a few times myself now)
Xaphiosis
approved these changes
Aug 24, 2023
corlewis
force-pushed
the
nondet_more_changes
branch
from
a4bc396
to
d6bf714
Compare
Signed-off-by: Corey Lewis <[email protected]>
Signed-off-by: Corey Lewis <[email protected]>
corlewis
force-pushed
the
nondet_more_changes
branch
from
a28e5b7
to
f436f34
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
More improvements to Nondet Monad, following on from #665. In general this improves style and some proofs, removes duplicate lemmas, and stays in sync with coming changes to Trace Monad.