make flags more intuitive #303
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
axel-h
force-pushed
the
patch-axel-3
branch
3 times, most recently
from
3dc862c
to
9bfaf54
Compare
axel-h
force-pushed
the
patch-axel-3
branch
3 times, most recently
from
efca536
to
e71c466
Compare
lsf37
reviewed
Jan 27, 2024
lsf37
reviewed
Jan 27, 2024
lsf37
approved these changes
Jan 27, 2024
There was a problem hiding this comment.
I think this makes sense. The simulation_binary setting is a relic from very old times and at best confusing, and no_hw_test is better in line with the rest of the terminology and the labels we use on repos.
@june-andronick if you're looking into what is tested, this PR will change the names of the keys you have to check for.
axel-h
force-pushed
the
patch-axel-3
branch
2 times, most recently
from
5bdd2cd
to
a420e62
Compare
- 'disabled' -> 'no_hw_test' - 'simulation_binary' -> 'has_simulation' as boolean Signed-off-by: Axel Heider <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
disabled->no_hw_testsimulation_binary->has_simulationas boolean