use ARM_MCS_verified.cmake for MCS build #295
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
axel-h
force-pushed
the
patch-axel-6
branch
3 times, most recently
from
69e872d
to
7aaf973
Compare
axel-h
force-pushed
the
patch-axel-6
branch
3 times, most recently
from
79f3f7a
to
e204c30
Compare
- remove redundancy - check if config file exists - remove unnecessary CMake parameters - use separate build folder for non-MCS and MCS - improve comments Signed-off-by: Axel Heider <[email protected]>
Signed-off-by: Axel Heider <[email protected]>
Signed-off-by: Axel Heider <[email protected]>
|
I'm fine with the MCS part, but we should not be putting in dummy files for configurations that are not under verification (as in the test run), because that will look misleading and we use the list of config files in a number of places to define which platforms are verified (so that would then also generate wrong info). I guess we could leave the options in this script, but just never call them in the build matrix, so when we do verify RV32 at some point, the test will already be there. In terms of test completeness, compilation for RV32 and x86 32-bit is covered by the simulation tests that also run on each PR, they're just missing from the quicker standalone compile check. |
lsf37
approved these changes
Jan 9, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
xxx_MCS_verified.cmakefor MCS builds if is exists (RISCV64, ARM), see ARM_MCS_verified.cmake not used by CI when running seL4/ci-actions/standalone-kernel #294A test run can be found at axel-h/seL4#131 (with some dummy config for RISCV32/IA32)