vm_arm: set fdt pointer and gic name #53
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit sets the fdt pointer and gic node, which are used by the libraries to find the registers necessary to emulate the gic. Signed-off-by: Chris Guikema <[email protected]>
axel-h
reviewed
Oct 27, 2022
| @@ -1156,6 +1157,9 @@ int main_continued(void) | |||
| ZF_LOGF_IF(err, "Failed to bind CB to SID"); | |||
| #endif /* CONFIG_ARM_SMMU */ | |||
|
|
|||
| vm.fdt_ori = (void *)ps_io_fdt_get(&_io_ops.io_fdt); | |||
| vm.gic_path = GIC_NODE_PATH; | |||
There was a problem hiding this comment.
Thanks for splitting the PRs up. Please add the usage of vm->gic_path in generate_fdt() also, so this is the only place where the path's default is set up from the plat constants.
axel-h
reviewed
Oct 27, 2022
| @@ -1156,6 +1157,9 @@ int main_continued(void) | |||
| ZF_LOGF_IF(err, "Failed to bind CB to SID"); | |||
| #endif /* CONFIG_ARM_SMMU */ | |||
|
|
|||
| vm.fdt_ori = (void *)ps_io_fdt_get(&_io_ops.io_fdt); | |||
There was a problem hiding this comment.
Will we replace all places where ps_io_fdt_get() is called by vm->fdt_ori then also? E.g. in load_linux() above?
|
What is you plan about this one? With #73 I have another use case where |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit sets the fdt pointer and gic node, which are used by the libraries to find the registers necessary to emulate the gic.
Test with: seL4/seL4_projects_libs#83