sharded.hh: seperate invoke_on decls from defs #2470
+93
−58
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
avikivity
reviewed
Oct 9, 2024
include/seastar/core/sharded.hh
Outdated
| @@ -784,6 +759,7 @@ sharded<Service>::stop() noexcept { | |||
| } | |||
|
|
|||
| template <typename Service> | |||
| inline | |||
There was a problem hiding this comment.
inlines aren't necessary for templates, and are a net negative for this compile time oriented function (though in practice, the compiler ignores the inline directive for inlining).
There was a problem hiding this comment.
will remove inline from templates in sharded.hh on a different PR
Seperate all invoke_on decls from defs on sharded class template for improved readability and loose coupling, maybe even as preparation for `extern template`. Also, and cluster `invoke_on(unsigned id, ...)` together with the other variants.
tomershafir
force-pushed
the
sharded-invoke-on-extract-decls
branch
from
838de85
to
d293b0f
Compare
tomershafir
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Seperate all invoke_on decls from defs on sharded class template for improved readability and loose coupling, maybe even as preparation for
extern template. Also, clusterinvoke_on(unsigned id, ...)together with the other variants.