-
Notifications
You must be signed in to change notification settings - Fork 1.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
github: s/ubuntu-latest/ubuntu-24.04/ #2316
base: master
Are you sure you want to change the base?
Conversation
1352a15
to
8ab6956
Compare
the workflows are failing due to #2302 |
pending on #2317 |
8ab6956
to
a85d803
Compare
I'm not sure I understand the benefit here. Would be good to compare runtimes. |
@mykaul take the "Test (clang++, C++, dev) / test as an example:
before this change, see https://github.com/scylladb/seastar/actions/runs/9741537615/job/26880954875 after this change, see https://github.com/scylladb/seastar/actions/runs/9741786724/job/26881705458 |
45 secs saving is noise level (IMHO) for CI. |
@mykaul i am not able to provide a statistically signifcant report at this moment, but i think to skip following steps
and to drop the unnecessary step in the workflow already deserve the change. |
@scylladb/seastar-maint hello maintainers, could you help review this change? i am seeing timeout when installing the dependencies recently. see |
@@ -50,16 +45,16 @@ jobs: | |||
- name: Install clang++ | |||
if: ${{ inputs.compiler == 'clang++' }} | |||
run: | | |||
sudo dnf -y install clang | |||
sudo apt-get -y install clang |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
What about apt-get update?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
sure. added.
Ubuntu 24.04 is now available, see actions/runner-images#9848 so instead of building and running the tests in a fedora 40 container, let's do the CI with the shinny ubuntu runner image, which preinstalls some of the necessary building dependencies, so in theory, it should be relatively faster than installing every package on fedora 40. and since we are now using an image with git pre-installed, there is no need to install `git` anymore. so, in this change, we drop the step to install `git`. because we are switching to a debian derivative distro, let's use apt-get instead of dnf to install packages. Signed-off-by: Kefu Chai <[email protected]>
a85d803
to
134e487
Compare
v2:
|
@avikivity could you take another look? |
Ubuntu 24.04 is now available, see
actions/runner-images#9848
so instead of building and running the tests in a fedora 40 container, let's do the CI with the shinny ubuntu runner image, which preinstalls some of the necessary building dependencies, so in theory, it should be relatively faster than installing every package on fedora 40.
and since we are now using an image with git pre-installed, there is no need to install
git
anymore. so, in this change, we drop the step to installgit
.because we are switching to a debian derivative distro, let's use apt-get instead of dnf to install packages.