Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: update theme 1.6 #4

Merged
merged 2 commits into from
Oct 11, 2023
Merged

docs: update theme 1.6 #4

merged 2 commits into from
Oct 11, 2023

Conversation

dgarcia360
Copy link
Collaborator

Related issue scylladb/sphinx-scylladb-theme#914

ScyllaDB Sphinx Theme 1.6 is out 🥳 We've introduced parallel builds for faster performance and added support for Git LFS. Now requiring Python 3.9 due to an upgrade to Sphinx 7.2.4. Note for Windows users: support for Git Bash is discontinued, switch to WSL is advised.

You can read more about all notable changes here.

How to test this PR

  1. Clone this PR. For more information, see Cloning pull requests locally.

  2. Enter the docs folder, and run:

    make preview
    
  3. Open http://localhost:5500 with your favorite browser. The doc should render without errors, and the version should be Sphinx Theme version (see the footer) must be 1.6.x:

image

@dgarcia360
Copy link
Collaborator Author

@annastuchlik ready for review

Copy link
Collaborator

@annastuchlik annastuchlik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@annastuchlik
Copy link
Collaborator

This PR looks good. Merging.

@annastuchlik annastuchlik merged commit d601338 into main Oct 11, 2023
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants