github/workflows/integration-tests: extract RELOC_VERSION as an env variable #567
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
see also #566 for the similar changes applied to |
|
@tchaikov please check why CI didn't run at all |
denesb
approved these changes
Mar 25, 2024
…variable so we can customize it if necessary. also, wire it up with "SCYLLA_VERSION" as another env variable, so it can be consumed by `test_config.py`. the same change has been already applied to nix.yml in 51e9d91 and 8666049. Signed-off-by: Kefu Chai <[email protected]>
…ey of cache encode RELOC_VERSION in the key of binary, so we can use different binary for testing. there is chance that newer ccm would like to use newer scylla executables for testing. the same change has been applied to nix.yml in 96ab738. Signed-off-by: Kefu Chai <[email protected]>
tchaikov
force-pushed
the
github-integration-tests-binary-cache
branch
from
7dfed77
to
3a45d1d
Compare
|
changelog:
|
|
@fruch ping? |
|
next step, i will extract the setting of scylla version into another yaml file as a dedicated action shared by these two existing action, so we don't need to repeat it in two workflows. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
encode
RELOC_VERSIONin the key of binary, so we can use different binary for testing. there is chance that newer ccm would like to use newer scylla executables for testing.this series is more a refactory, and it does not change the version of scylla we are using, but in a follow up change, we will use a different
RELOC_VERSIONfor testing newer scylla.