-
Notifications
You must be signed in to change notification settings - Fork 66
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ccmlib/scylla_repository: introduce get_manger_* functions #474
Conversation
Architecture = Literal['x86_64', 'aarch64'] | ||
|
||
|
||
def get_manager_latest_reloc_url(branch: str = "master", architecture: Architecture = None) -> str: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
if we want to enforce type annotations, we might need to, well, enforce it. like
def get_manager_latest_reloc_url(branch: str = "master", architecture: Optional[Architecture] = None) -> str:
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It's mostly for documentation now, not going to enforce it with tools.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
yes, if we want to use for document, i think we need to get it right from the very beginning.
a6a5092
to
76fa918
Compare
those helper function could be user to retrive scylla manager relocatable packages, that we need in dtest for testing manager, those comes in two flavors: * one to retrive lastet version of of specific branches * one to retrive specific released versions
76fa918
to
11221e5
Compare
those helper function could be user to retrive scylla manager relocatable packages, that we need in dtest for testing manager, those comes in two flavors: