Skip to content

Commit

Permalink
fix(#304): wait a bit more when killing scylla-jmx on timeout
Browse files Browse the repository at this point in the history
The `SIGQUIT` is follow too soon by a forcefull kill, i.e. we don't let
the process enough time to print the output to stdout

Close: #303
Ref: scylladb/scylladb#7991 (comment)
  • Loading branch information
fruch committed Feb 14, 2021
1 parent 811bf0c commit bc4dced
Showing 1 changed file with 1 addition and 0 deletions.
1 change: 1 addition & 0 deletions ccmlib/scylla_node.py
Original file line number Diff line number Diff line change
Expand Up @@ -660,6 +660,7 @@ def nodetool(self, *args, **kwargs):
except subprocess.TimeoutExpired:
self.error("nodetool timeout, going to kill scylla-jmx with SIGQUIT")
self.kill_jmx(signal.SIGQUIT)
time.sleep(5) # give the java process time to print the threaddump into the log
raise

def kill_jmx(self, __signal):
Expand Down

0 comments on commit bc4dced

Please sign in to comment.