Warn if consistency level is overridden #325
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dkropachev
force-pushed
the
dk/4-x-warn-if-consistency-level-is-overriden
branch
7 times, most recently
from
e591e16
to
23b5dfb
Compare
dkropachev
force-pushed
the
dk/4-x-warn-if-consistency-level-is-overriden
branch
from
23b5dfb
to
36e6dad
Compare
Bouncheck
requested changes
Aug 26, 2024
core/src/main/java/com/datastax/oss/driver/internal/core/cql/DefaultPrepareRequest.java
Outdated
Show resolved
Hide resolved
non-default consistancy level is in the batch
When user does:
```
SimpleStatement simpleStatement = SimpleStatement.builder("SELECT * FROM some_table WHERE a = ?")
.setConsistencyLevel(DefaultConsistencyLevel.QUORUM).build();
batchStatementBuilder.addStatement(simpleStatement);
batchStatementBuilder.build();
```
Child statement looses it's consistancy level, which is confusing.
To warn user it is happening driver will issue log warning.
dkropachev
force-pushed
the
dk/4-x-warn-if-consistency-level-is-overriden
branch
from
36e6dad
to
642ba46
Compare
Bouncheck
approved these changes
Aug 27, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #304
In some cases consistency level is being lost, which is not obvious to the user.
To remedy that we will issue a log working when it is happening.
Addresses following cases:
And