Fix unmarshall errors, add condition for nil reference
#301
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dkropachev
requested changes
Oct 9, 2024
marshal/cqlint/unmarshal_utils.go
Outdated
| @@ -323,7 +399,7 @@ func decReflectInt8(p []byte, v reflect.Value) error { | |||
| case 4: | |||
| val := decInt32(p) | |||
| if val > math.MaxInt8 || val < math.MinInt8 { | |||
| return fmt.Errorf("failed to unmarshal int: to unmarshal into int8, the data should be in the int8 range") | |||
| return fmt.Errorf("failed to unmarshal int: to unmarshal into custom int8, the data should be in the int8 range") | |||
There was a problem hiding this comment.
Suggested change
| return fmt.Errorf("failed to unmarshal int: to unmarshal into custom int8, the data should be in the int8 range") | |
| return fmt.Errorf("failed to unmarshal int: to unmarshal into %T, the data should be in the int8 range", v.Interface()) |
illia-li
force-pushed
the
il/fix/marshal/nil_reference
branch
from
c970f62
to
e25a17d
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added for
smallint,int,bigint,countercql types.Additional fixed
errors textfortinyintcql type