Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix counter marshal, unmarshall #293

Merged
merged 2 commits into from
Oct 8, 2024

Conversation

illia-li
Copy link

@illia-li illia-li commented Oct 4, 2024

Fixed for counter type:

  1. string marshal and unmarshal as nullable.
    1.1. Before: marshals "" - caused an error; unmarshals nil data into "0".
    1.2. Now: marshals and unmarshals nil data - "".
  2. custom string marshals and unmarshals, before not supported, now supported.
  3. big.Int marshals, before not supported, now supported.
  4. Marshal data, which equal math.MaxUint64, into uint64, uint, return error' before, now no error`.
  5. Unmarshall data with the length is different from 0 and 8, did not return error before, now it returns `error'.

Close issues for counter:

  1. Marshal, unmarshal. For many cql types unmarshaling data that have bigger len than cql type, do not return an error. #246
  2. Marshal, unmarshal. For many cql types a go string is supported, but not a go custom string #243
  3. Marshal, unmarshal. cql types: tinyint, smallint, int can not be marshaled into go big.Int #244
  4. Marshal, unmarshal. Problems with zero and null data and values. #250
  5. Marshal, unmarshal. For many cql types unmarshaling data that have smaller len than cql type, do not return an error. #252

@illia-li illia-li force-pushed the il/fix/marshal/counter branch 4 times, most recently from 0d764b3 to 42e30e6 Compare October 7, 2024 18:46
dkropachev
dkropachev previously approved these changes Oct 8, 2024
@dkropachev
Copy link
Collaborator

@illia-li , please rebase

@illia-li
Copy link
Author

illia-li commented Oct 8, 2024

@illia-li , please rebase

Done

@dkropachev dkropachev merged commit 8b3d4ce into scylladb:master Oct 8, 2024
1 check passed
@illia-li illia-li deleted the il/fix/marshal/counter branch October 9, 2024 17:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants