(fix): gpu ci uses max version from pyproject.toml

[ilan-gold]

• Closes #
• Tests added
• Release note added (or unnecessary)

[flying-sheep]

You could also use this: https://github.com/marketplace/actions/cargo-install

[ilan-gold]

ah was looking for something like this just now. I also thought cargo came on the ubuntu images by default but evidently not install?

Also, do you think we should be doing this for all of our CI i.e., extracting from pyproject.toml?

[ilan-gold]

Ok I think that is only for rust projects: https://github.com/scverse/anndata/actions/runs/11330444061/job/31508293550?pr=1714

Hmm no, I think this may be what I saw before actually. Github needs the cargo path without a rust project so I think I'll just go back

[flying-sheep]

I still think that using that action is better, because it sets up PATH and uses caching.

[ilan-gold]

https://github.com/scverse/anndata/actions/runs/11330444061/job/31508293550 Not sure

[ilan-gold]

I read this as cargo not being on the path

[codecov]

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 86.93%. Comparing base (27eaf39) to head (ad70b7d).
Report is 1 commits behind head on main.

Additional details and impacted files

@@            Coverage Diff             @@
##             main    #1714      +/-   ##
==========================================
+ Coverage   84.45%   86.93%   +2.48%     
==========================================
  Files          40       40              
  Lines        6039     6039              
==========================================
+ Hits         5100     5250     +150     
+ Misses        939      789     -150     

see 8 files with indirect coverage changes

[flying-sheep]

Awesome! I’m not a huge fan of most¹ short-form CLI parameters, so if you could switch the more obscure ones to long-form I’d even be happier.

Also \K means something regarding capture right? If I’m right, maybe use a capture group instead, I think people are more likely to know that one. Otherwise please add a comment explaining what it is.

Footnotes

1. except super-well known ones like something -vv, grep -P/-E, or tail -n1/-c5 or so ↩

[ilan-gold]

I aim to please :)

[flying-sheep]

Ah great, now I understand what’s going on!