[FIX] sha256 witness issue (#1081) #1087
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
lgtm. (since limechain may test develop i wil merge it now) |
vladimir-trifonov
pushed a commit
to LimeChain/scroll-zkevm-circuits
that referenced
this pull request
Jan 19, 2024
* reproduce phase issues in sha256_circuit * fix issues * fmt and clippy * fix gate issue --------- Co-authored-by: kunxian xia <[email protected]>
vladimir-trifonov
pushed a commit
to LimeChain/scroll-zkevm-circuits
that referenced
this pull request
Jan 19, 2024
* reproduce phase issues in sha256_circuit * fix issues * fmt and clippy * fix gate issue --------- Co-authored-by: kunxian xia <[email protected]>
vladimir-trifonov
pushed a commit
to LimeChain/scroll-zkevm-circuits
that referenced
this pull request
Jan 19, 2024
* reproduce phase issues in sha256_circuit * fix issues * fmt and clippy * fix gate issue --------- Co-authored-by: kunxian xia <[email protected]>
vladimir-trifonov
pushed a commit
to LimeChain/scroll-zkevm-circuits
that referenced
this pull request
Jan 24, 2024
* reproduce phase issues in sha256_circuit * fix issues * fmt and clippy * fix gate issue --------- Co-authored-by: kunxian xia <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fix issue #1081.
It is caused by copy assigning cells from phase2 col into phase1 col. In the first pass such phase 1 cells would not be assigned and lead to a complain of 'Syntheis' from halo2.