Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

witness assignment of sha256 circuit has bug #1081

Open
kunxian-xia opened this issue Jan 11, 2024 · 1 comment
Open

witness assignment of sha256 circuit has bug #1081

kunxian-xia opened this issue Jan 11, 2024 · 1 comment

Comments

@kunxian-xia
Copy link

kunxian-xia commented Jan 11, 2024 •
edited
Loading

What command(s) is the bug in?

RUST_LOG=debug cargo test --release --package zkevm-circuits --lib vk_stable -- --nocapture

Describe the bug

Some 1st phase column's value is assigned to be None which must not be the case.

Concrete steps to reproduce the bug. If it's able reproduce via testool, please share test_id from jenkins report

Use the branch bug/sha256 and then run the above cmd.
@noel2004 noel2004 mentioned this issue Jan 14, 2024
Merged
@noel2004
Copy link
Member

Has been fixed:

It is caused by copy assigning cells from phase2 col into phase1 col. In the first pass such phase 1 cells would not be assigned and lead to a complain of 'Syntheis' from halo2.

lispc pushed a commit that referenced this issue Jan 16, 2024
@noel2004 @kunxian-xia
[FIX] sha256 witness issue (#1081) (#1087)
d776b47 
* reproduce phase issues in sha256_circuit

* fix issues

* fmt and clippy

* fix gate issue

---------

Co-authored-by: kunxian xia <[email protected]>
vladimir-trifonov pushed a commit to LimeChain/scroll-zkevm-circuits that referenced this issue Jan 19, 2024
@lastminutedev @kunxian-xia
[FIX] sha256 witness issue (scroll-tech#1081) (scroll-tech#1087)
ba2c2d1 
* reproduce phase issues in sha256_circuit

* fix issues

* fmt and clippy

* fix gate issue

---------

Co-authored-by: kunxian xia <[email protected]>
vladimir-trifonov pushed a commit to LimeChain/scroll-zkevm-circuits that referenced this issue Jan 19, 2024
@lastminutedev @kunxian-xia
[FIX] sha256 witness issue (scroll-tech#1081) (scroll-tech#1087)
3d6d340 
* reproduce phase issues in sha256_circuit

* fix issues

* fmt and clippy

* fix gate issue

---------

Co-authored-by: kunxian xia <[email protected]>
vladimir-trifonov pushed a commit to LimeChain/scroll-zkevm-circuits that referenced this issue Jan 19, 2024
@lastminutedev @kunxian-xia
[FIX] sha256 witness issue (scroll-tech#1081) (scroll-tech#1087)
134514f 
* reproduce phase issues in sha256_circuit

* fix issues

* fmt and clippy

* fix gate issue

---------

Co-authored-by: kunxian xia <[email protected]>
vladimir-trifonov pushed a commit to LimeChain/scroll-zkevm-circuits that referenced this issue Jan 24, 2024
@lastminutedev @kunxian-xia
[FIX] sha256 witness issue (scroll-tech#1081) (scroll-tech#1087)
a84db85 
* reproduce phase issues in sha256_circuit

* fix issues

* fmt and clippy

* fix gate issue

---------

Co-authored-by: kunxian xia <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@kunxian-xia @noel2004