[feat] prover support sp1 proof #344
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: noelwei <[email protected]>
Signed-off-by: noelwei <[email protected]>
Signed-off-by: noelwei <[email protected]>
Signed-off-by: noelwei <[email protected]>
Signed-off-by: noelwei <[email protected]>
Signed-off-by: noelwei <[email protected]>
Signed-off-by: noelwei <[email protected]>
Signed-off-by: noelwei <[email protected]>
Signed-off-by: noelwei <[email protected]>
Signed-off-by: noelwei <[email protected]>
Signed-off-by: noelwei <[email protected]>
Signed-off-by: noelwei <[email protected]>
Signed-off-by: noelwei <[email protected]>
Signed-off-by: noelwei <[email protected]>
Signed-off-by: noelwei <[email protected]>
Signed-off-by: noelwei <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR tried to integrate tests for sp1 proofs, without additional updated being needed in
zkevm-circuit.Basically, it supposed any proofs from sp1 is ready beforehand and put into a specified directory by
SP1_PATHenv variable. For each chunk the corresponding snark proof in sp1 path should be named assp1_snark_<chunk_identifier>.jsonThe e2e test has been updatd, also, new unit tests is added as following:
test_sp1_chunk_prove_verify: test a specified chunk with given sp1 snark proof, to confirm it can be compressed with layer2 circuittest_batch_prove_verify_after_chunk_tests: a ignored unittest which enable user to test if the proof from a completed chunk test can be further integrated into batch circuit (layer3 and layer4)