Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FIX] Chunk builder's block limit #335

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

noel2004
Copy link
Member

When chunk builder deliver chunk data with block limit condition, the original code do not reset the ccc result.

As the result, the following add call would deliver a empty collection of chunks and panic.

This PR fix the issue and add enviroment variant (CHUNK_BLOCK_LIMIT) for setting the block limit of chunk builder.

For not-set, thhe block limit is kept as original code (1) and to enable unlimit of blocks, use CHUNK_BLOCK_LIMIT=0

@lispc
Copy link
Collaborator

lispc commented Aug 13, 2024

i guess you find this bug by set block_limit > 1?

@noel2004
Copy link
Member Author

i guess you find this bug by set block_limit > 1?

yes

@0xShankar
Copy link

Try Block_limit

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants