Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Set dont_filter=True on additional requests #199

Merged
merged 2 commits into from
Jun 10, 2024
Merged

Set dont_filter=True on additional requests #199

merged 2 commits into from
Jun 10, 2024

Conversation

Gallaecio
Copy link
Member

No description provided.

@Gallaecio Gallaecio requested review from kmike, wRAR and BurnzZ June 7, 2024 13:56
@Gallaecio
Skip test_additional_requests_dont_filter_offsite on Scrapy versions …
261073b 
…where the offside middleware is still a spider middleware
kmike
kmike approved these changes Jun 7, 2024
View reviewed changes
Copy link
Member

@kmike kmike left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Makes sense!

@Gallaecio Gallaecio merged commit 7c079f0 into scrapinghub:master Jun 10, 2024
14 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kmike kmike kmike approved these changes

@BurnzZ BurnzZ BurnzZ approved these changes

@wRAR wRAR Awaiting requested review from wRAR

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Gallaecio @kmike @BurnzZ