Drop python 3.7 support (#155)

scrapinghub · Aug 29, 2023 · fe05a20 · fe05a20
1 parent f8c39ef
commit fe05a20
Show file tree

Hide file tree

Showing 6 changed files with 13 additions and 13 deletions.
diff --git a/.github/workflows/test.yml b/.github/workflows/test.yml
@@ -16,13 +16,13 @@ jobs:
       fail-fast: false
       matrix:
         include:
-        - python-version: "3.7"
+        - python-version: "3.8"
           toxenv: "min"
-        - python-version: "3.7"
+        - python-version: "3.8"
           toxenv: "pinned-scrapy-2x7"
-        - python-version: "3.7"
+        - python-version: "3.8"
           toxenv: "pinned-scrapy-2x8"
-        - python-version: "3.7"
+        - python-version: "3.8"
           toxenv: "asyncio-min"
         - python-version: "3.8"
         - python-version: "3.9"

diff --git a/README.rst b/README.rst
@@ -48,7 +48,7 @@ Installation
 
     pip install scrapy-poet
 
-Requires **Python 3.7+** and **Scrapy >= 2.6.0**.
+Requires **Python 3.8+** and **Scrapy >= 2.6.0**.
 
 Usage in a Scrapy Project
 =========================

diff --git a/docs/intro/install.rst b/docs/intro/install.rst
@@ -7,7 +7,7 @@ Installation
 Installing scrapy-poet
 ======================
 
-``scrapy-poet`` is a Scrapy extension that runs on Python 3.7 and above.
+``scrapy-poet`` is a Scrapy extension that runs on Python 3.8 and above.
 
 If you’re already familiar with installation of Python packages, you can install
 ``scrapy-poet`` and its dependencies from PyPI with:

diff --git a/setup.py b/setup.py
@@ -38,7 +38,6 @@
         "Operating System :: OS Independent",
         "Framework :: Scrapy",
         "Programming Language :: Python :: 3",
-        "Programming Language :: Python :: 3.7",
         "Programming Language :: Python :: 3.8",
         "Programming Language :: Python :: 3.9",
         "Programming Language :: Python :: 3.10",

diff --git a/tests/test_injection.py b/tests/test_injection.py
@@ -287,7 +287,7 @@ class OtherEurDollarRate(Injectable):
 
 @attr.s(auto_attribs=True)
 class PricePO(ItemPage, ResponseShortcutsMixin):
-    response: Html
+    response: Html  # type: ignore[assignment]
 
     def to_item(self):
         return dict(price=float(self.css(".price::text").get()), currency="€")

diff --git a/tox.ini b/tox.ini
@@ -1,11 +1,12 @@
 [tox]
-envlist = min,py37,py38,py39,py310,py311,asyncio,asyncio-min,mypy,docs
+envlist = min,py38,py39,py310,py311,asyncio,asyncio-min,mypy,docs
 
 [testenv]
 deps =
     pytest
     pytest-cov
     pytest-twisted
+    Twisted<=22.10.0
 
 commands =
     py.test \
@@ -24,7 +25,7 @@ deps =
     web-poet==0.7.0
 
 [testenv:min]
-basepython = python3.7
+basepython = python3.8
 deps =
     {[pinned]deps}
     scrapy==2.6.0
@@ -38,15 +39,15 @@ deps =
 # Before ``scrapy.http.request.NO_CALLBACK`` was introduced.
 # See: https://github.com/scrapinghub/scrapy-poet/issues/48
 [testenv:pinned-scrapy-2x7]
-basepython=python3.7
+basepython=python3.8
 deps =
     {[pinned]deps}
     scrapy==2.7.0
 
 # After ``scrapy.http.request.NO_CALLBACK`` was introduced.
 # See: https://github.com/scrapinghub/scrapy-poet/issues/118
 [testenv:pinned-scrapy-2x8]
-basepython=python3.7
+basepython=python3.8
 deps =
     {[pinned]deps}
     scrapy==2.8.0
@@ -60,7 +61,7 @@ deps =
     {[pinned]deps}
 
 [testenv:asyncio-min]
-basepython = python3.7
+basepython = python3.8
 setenv =
     {[testenv:asyncio]setenv}
 commands =