Skip to content

Commit

Permalink
make_crawler: do not change setting priorities (#197)
Browse files Browse the repository at this point in the history
  • Loading branch information
Gallaecio committed Apr 25, 2024
1 parent 2946c28 commit bbffb57
Showing 1 changed file with 8 additions and 1 deletion.
9 changes: 8 additions & 1 deletion scrapy_poet/utils/testing.py
Original file line number Diff line number Diff line change
Expand Up @@ -159,7 +159,14 @@ def get_download_handler(crawler, schema):

def make_crawler(spider_cls, settings=None):
settings = settings or {}
settings = {**create_scrapy_settings(), **settings}
if isinstance(settings, dict):
_settings = create_scrapy_settings()
_settings.update(settings)
else:
_settings = create_scrapy_settings()
for k, v in dict(settings).items():
_settings.set(k, v, priority=settings.getpriority(k))
settings = _settings

if not getattr(spider_cls, "name", None):

Expand Down

0 comments on commit bbffb57

Please sign in to comment.