Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Apply easy fixes/inspections #331

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

mdedetrich
Copy link
Contributor

@mdedetrich mdedetrich commented Oct 1, 2024

This PR applies easy inspections/fixes found within Intellij + some others i.e.

  • Optimizing/reorganizing imports
  • Adding types to public methods (this was skipped in tests since its kind of pointless there)
  • Adding types to implicit definitions (this is a requirement in Scala 3 and good practice in general)
  • Naming boolean parameters
  • Making case class final (case class should really be final by default because overriding a case class can break expected that is expected of a case class)
  • Using _ initializer instead of null
  • Adding @tailrec for methods which are tail call recursive
  • Make traits extend Product and Serializable to make types nicer (see https://stackoverflow.com/a/36526562)

All in all, none of these changes should be that controversial

@mdedetrich mdedetrich force-pushed the apply-easy-fixes branch 2 times, most recently from 9514264 to 4bca800 Compare October 1, 2024 10:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant