Disk/memory modes of PersHelper #25
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MandaloreUltimate
force-pushed
the
feature/pipe-comm
branch
2 times, most recently
from
ad7c34f
to
f4f6b56
Compare
…rsistence, add unit tests.
MandaloreUltimate
force-pushed
the
feature/pipe-comm
branch
from
f4f6b56
to
c7b8af6
Compare
elwer
reviewed
May 2, 2024
src/scorep_jupyter/kernel.py
Outdated
| self.pershelper = PersHelper('cloudpickle') | ||
|
|
||
| self.cell_output(f'Serializer backend switched to {serializer}, persistence was reset.') | ||
| if serializer in ['dill', 'cloudpickle']: |
There was a problem hiding this comment.
can we have something non-static here, e.g. a config file so that we could support user-defined serializer as well? In the future, we don't want to change the code to plugin an alternative serializer.
elwer
reviewed
May 7, 2024
| def serializer_settings(self, serializer, mode): | ||
| error_message = "" | ||
|
|
||
| if serializer in ['dill', 'cloudpickle']: |
There was a problem hiding this comment.
please also catch the following cases:
- no serializer set -> use default one
- no communication set -> use default one
for both cases, please print the whole configuration (serializer and mode that is used)
elwer
reviewed
May 7, 2024
| if os.path.exists(scorep_script_name): | ||
| os.remove(scorep_script_name) | ||
|
|
||
| def serializer_settings(self, serializer, mode): |
There was a problem hiding this comment.
following the comment from the other conversation, please try to make it as configurable as possible, i.e. in the future we might want to add custom serializers here
elwer
reviewed
May 7, 2024
MandaloreUltimate
force-pushed
the
feature/pipe-comm
branch
2 times, most recently
from
3a3ae4a
to
1bb31cb
Compare
MandaloreUltimate
force-pushed
the
feature/pipe-comm
branch
from
1bb31cb
to
92d90a8
Compare
elwer
approved these changes
May 10, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Extend
PersHelperclass to support "disk" and "memory" ways of communicating the persistence between Jupyter and subprocess - using either files or pipes respectively.PersHelpercan now be configured with the following magic: