Iván Pérez

src/main/java/com/scmspain/MsFcTechTestApplication.java

@@ -1,18 +1,17 @@
 package com.scmspain;
 
-import com.scmspain.configuration.InfrastructureConfiguration;
-import com.scmspain.configuration.TweetConfiguration;
 import org.springframework.boot.SpringApplication;
 import org.springframework.boot.autoconfigure.EnableAutoConfiguration;
-import org.springframework.boot.autoconfigure.SpringBootApplication;
+import org.springframework.context.annotation.ComponentScan;
 import org.springframework.context.annotation.Configuration;
-import org.springframework.context.annotation.Import;
 
 @Configuration
 @EnableAutoConfiguration
-@Import({TweetConfiguration.class, InfrastructureConfiguration.class})
+@ComponentScan(basePackageClasses = { MsFcTechTestApplication.class })
 public class MsFcTechTestApplication {
+
     public static void main(String[] args) {
         SpringApplication.run(MsFcTechTestApplication.class, args);
     }
+
 }

src/main/java/com/scmspain/application/services/TweetMetricService.java

@@ -0,0 +1,53 @@
+package com.scmspain.application.services;
+
+import java.util.List;
+
+import com.scmspain.domain.MetricService;
+import com.scmspain.domain.TweetNotFoundException;
+import com.scmspain.domain.TweetService;
+import com.scmspain.domain.model.TweetResponse;
+
+/**
+ * Tweet service implementation that adds metric to another wrapped tweet service.
+ */
+public class TweetMetricService implements TweetService {
+
+    private final MetricService metricService;
+    private final TweetService tweetService;
+
+    /**
+     * Constructor.
+     *
+     * @param tweetService Tweet service to wrap.
+     * @param metricService Metrics service.
+     */
+    public TweetMetricService(final TweetService tweetService, final MetricService metricService) {
+        this.tweetService = tweetService;
+        this.metricService = metricService;
+    }
+
+    @Override
+    public Long publish(String publisher, String text) {
+        metricService.incrementPublishedTweets();
+        return tweetService.publish(publisher, text);
+    }
+
+    @Override
+    public List<TweetResponse> listAll() {
+        metricService.incrementTimesQueriedTweets();
+        return tweetService.listAll();
+    }
+
+    @Override
+    public void discard(Long tweetId) throws TweetNotFoundException {
+        metricService.incrementDiscardedTweets();
+        tweetService.discard(tweetId);
+    }
+
+    @Override
+    public List<TweetResponse> listAllDiscarded() {
+        metricService.incrementTimesQueriedDiscardedTweets();
+        return tweetService.listAllDiscarded();
+    }
+
+}

src/main/java/com/scmspain/application/services/TweetValidationService.java

@@ -0,0 +1,73 @@
+package com.scmspain.application.services;
+
+import java.util.List;
+
+import com.scmspain.domain.TweetNotFoundException;
+import com.scmspain.domain.TweetService;
+import com.scmspain.domain.model.TweetResponse;
+
+/**
+ * Tweet service implementation that adds validation to another wrapped tweet service.
+ */
+public class TweetValidationService implements TweetService {
+
+    private static final int MAX_CHARACTERS = 140;
+
+    private final TweetService tweetService;
+    private final UrlRemover urlRemover;
+
+    /**
+     * Constructor.
+     *
+     * @param tweetService Tweet service to wrap.
+     */
+    public TweetValidationService(final TweetService tweetService) {
+        this.tweetService = tweetService;
+        this.urlRemover = new UrlRemover();
+    }
+
+    @Override
+    public Long publish(final String publisher, final String text) {
+        if (publisherEmpty(publisher)) {
+            throw new IllegalArgumentException("Publisher must not be empty");
+        }
+        if (textEmpty(text)) {
+            throw new IllegalArgumentException("Tweet must not be empty");
+        }
+        if (textTooLong(text)) {
+            throw new IllegalArgumentException("Tweet must not be greater than " + MAX_CHARACTERS + " characters");
+        }
+        return this.tweetService.publish(publisher, text);
+    }
+
+    @Override
+    public List<TweetResponse> listAll() {
+        return tweetService.listAll();
+    }
+
+    @Override
+    public void discard(Long tweetId) throws TweetNotFoundException {
+        if (tweetId == null) {
+            throw new IllegalArgumentException("Tweet identifier must not be empty");
+        }
+        this.tweetService.discard(tweetId);
+    }
+
+    @Override
+    public List<TweetResponse> listAllDiscarded() {
+        return tweetService.listAllDiscarded();
+    }
+
+    private boolean textEmpty(final String text) {
+        return text == null || text.isEmpty();
+    }
+
+    private boolean publisherEmpty(final String publisher) {
+        return publisher == null || publisher.isEmpty();
+    }
+
+    private boolean textTooLong(final String text) {
+        return urlRemover.removeUrls(text).length() > MAX_CHARACTERS;
+    }
+
+}

src/main/java/com/scmspain/application/services/UrlExtractor.java

@@ -0,0 +1,73 @@
+package com.scmspain.application.services;
+
+import java.util.ArrayList;
+import java.util.List;
+import java.util.Optional;
+
+/**
+ * Extract URLs from a String for some protocols.
+ */
+public class UrlExtractor {
+
+    private static final String WHITE_SPACE = " ";
+    private static final String HTTP_PROTOCOL = "http://";
+    private static final String HTTPS_PROTOCOL = "https://";
+
+    private String text;
+    private List<String> urls = new ArrayList<>();
+
+    public UrlExtractor(final String text) {
+        this.text = text;
+        this.extractUrls();
+    }
+
+    public String getText() {
+        return text;
+    }
+
+    public List<String> getUrls() {
+        return urls;
+    }
+
+    private void extractUrls() {
+        extractUrls(HTTP_PROTOCOL);
+        extractUrls(HTTPS_PROTOCOL);
+    }
+
+    private void extractUrls(final String protocol) {
+        Optional<String> url = extractUrl(protocol);
+        if (url.isPresent()) {
+            text = text.replace(url.get(), getEscapeIndex(urls.size()));
+            urls.add(url.get());
+            extractUrl(protocol);
+        }
+    }
+
+    private Optional<String> extractUrl(String protocol) {
+        int urlStart = text.indexOf(protocol);
+        if (urlStart != -1) {
+            int urlEnd = text.indexOf(WHITE_SPACE, urlStart);
+            if (urlEnd != -1) {
+                return Optional.of(text.substring(urlStart, urlEnd));
+            } else {
+                return Optional.of(text.substring(urlStart));
+            }
+        }
+        return Optional.empty();
+    }
+
+    public static String rebuild(String text, List<String> urls) {
+        for (int i = 0; i < urls.size(); i++) {
+            String target = getEscapeIndex(i);
+            while (text.contains(target)) {
+                text = text.replace(target, urls.get(i));
+            }
+        }
+        return text;
+    }
+
+    private static String getEscapeIndex(int index) {
+        return "{" + index + "}";
+    }
+
+}

src/main/java/com/scmspain/application/services/UrlRemover.java

@@ -0,0 +1,40 @@
+package com.scmspain.application.services;
+
+/**
+ * Remove URLs from a String for some protocols.
+ */
+class UrlRemover {
+
+    private static final String WHITE_SPACE = " ";
+    private static final String HTTP_PROTOCOL = "http://";
+    private static final String HTTPS_PROTOCOL = "https://";
+
+    /**
+     * Given a text removes the URLs contained on it.
+     *
+     * @param text Text.
+     * @return Text without URLs.
+     */
+    String removeUrls(final String text) {
+        String cleanText = removeUrls(text, HTTP_PROTOCOL);
+        return removeUrls(cleanText, HTTPS_PROTOCOL);
+    }
+
+    private String removeUrls(final String text, final String protocol) {
+        if (text.contains(protocol)) {
+            String newText = removeUrl(text, protocol);
+            return removeUrls(newText, protocol);
+        }
+        return text;
+    }
+
+    private String removeUrl(String text, String protocol) {
+        int urlStart = text.indexOf(protocol);
+        int urlEnd = text.indexOf(WHITE_SPACE, urlStart);
+        if (urlEnd == -1) {
+            return text.substring(0, urlStart);
+        }
+        return text.substring(0, urlStart) + text.substring(urlEnd + 1);
+    }
+
+}

src/main/java/com/scmspain/domain/MetricService.java

@@ -0,0 +1,28 @@
+package com.scmspain.domain;
+
+/**
+ * Metric service.
+ */
+public interface MetricService {
+
+    /**
+     * Increment by one the published tweets metrics.
+     */
+    void incrementPublishedTweets();
+
+    /**
+     * Increment by one the times queried tweets metrics.
+     */
+    void incrementTimesQueriedTweets();
+
+    /**
+     * Increment by one the discarded tweets metrics.
+     */
+    void incrementDiscardedTweets();
+
+    /**
+     * Increment by one the times queried discarded tweets metrics.
+     */
+    void incrementTimesQueriedDiscardedTweets();
+
+}

src/main/java/com/scmspain/domain/TweetNotFoundException.java

@@ -0,0 +1,11 @@
+package com.scmspain.domain;
+
+import com.scmspain.domain.command.CommandException;
+
+public class TweetNotFoundException extends CommandException {
+
+    public TweetNotFoundException(Long id) {
+        super(String.format("Tweet with identifier %s not found", id));
+    }
+
+}